Fix/issue54 multiple example tables #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a vacation this week. I'll try to review this early next week. Thank you @Wayne-Morgan for your contribution. |
|
@Wayne-Morgan In the meantime though, if you want to resolve the merge conflict that would be 💯. |
|
Thanks @brentleyjones. I'll look forward to your feedback. |
brentleyjones
approved these changes
May 4, 2017
|
Yeah. Sorry about that. My editor is set to remove trailing whitespace, and I didn't realise until after the commit. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch addresses issue #54. There were three changes required to fix the issue:
Fix invocationForScenarioOutline so it uses the appropriate examples table. example is passed in to the method rather than just taking the first.
Add tags to the CCIExample class. Populate the tags from the dictionary provided by the parser.
Change the filtering in CCIFeaturesManager to respect the examples tags: For any scenario outline which is not excluded, remove any examples which are excluded, and then remove the scenario outline if all examples have been removed. For any scenario outline which has not been included, remove any examples which have not been included, and then remove the scenario outline if all examples have been removed.