feat: more efficient rpc queries #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jun 20, 2023
| @@ -173,6 +169,7 @@ const SmartWalletConnection = ({ | |||
| const followPublished = <T extends {}>(path) => | |||
| makeFollower<T>(`:published.${path}`, leader, { | |||
| unserializer: context.fromMyWallet, | |||
| proof: 'none', | |||
There was a problem hiding this comment.
this seems reasonable for the use cases but let's develop an AttackersGuide.md for this repo to make clear what the security threats are
| ]; | ||
| }; | ||
|
|
||
| export const batchVstorageQuery = ( |
There was a problem hiding this comment.
looking forward to this living in ui-kit with test coverage
Deploying with
|
| Latest commit: |
44da9d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d375cfaf.wallet-app.pages.dev |
| Branch Preview URL: | https://batch-queries.wallet-app.pages.dev |
samsiegart
force-pushed
the
batch-queries
branch
from
c300c37 to
44da9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs Agoric/agoric-sdk#6870
Description
This uses the batch query client where possible, reducing rpc load by 90%+
We still need to use casting to follow wallet updates, because offer status updates are transient, so we need to watch them losslessly. However, I disabled proofs to reduce a lot of the extra queries there.
Copied the query client from
dapp-interintowallet/src/rpcbecause I started this already, but would like to pull that into a shared component in Agoric/ui-kitTesting
Tested provisioning a smart wallet, doing a psm swap on ollinet