Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cosmos 0.46 gov breaking changes #8902

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Feb 13, 2024

closes: #8887
closes: #8871
closes: #8885

Description

Cosmos 0.46 introduced some breaking changes to the governance module. This picks up the fixes and backward compatibility from our cosmos-sdk fork, and handles the remaining effects.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Core eval governance flow tested in a3p in follow-up #8901

Upgrade Considerations

Same as original 0.46 cosmos-sdk upgrade

@mhofman mhofman added the force:integration Force integration tests to run on PR label Feb 13, 2024
@mhofman mhofman marked this pull request as ready for review February 13, 2024 01:36
@mhofman mhofman added automerge:rebase Automatically rebase updates, then merge and removed force:integration Force integration tests to run on PR labels Feb 13, 2024
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhofman mhofman force-pushed the mhofman/8887-fix-governance branch from 8238814 to 47be563 Compare February 13, 2024 03:10
@mhofman mhofman force-pushed the mhofman/8887-fix-governance branch from 47be563 to 229b36f Compare February 13, 2024 03:58
@mergify mergify bot merged commit 61af4a8 into master Feb 13, 2024
67 checks passed
@mergify mergify bot deleted the mhofman/8887-fix-governance branch February 13, 2024 04:29
mhofman pushed a commit that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
2 participants