feat: agd query vstorage trailing slash for children #8637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Dec 11, 2023
Comment on lines
44
to
45
| // if path ends with '/' then remove it | ||
| if path[len(path)-1] == '/' { |
There was a problem hiding this comment.
'/' seems sort of arbitrary for a vstorage path. I'd expect something more coherent to that model, like a trailing '.'. WDYT?
|
I think I'd prefer a new |
turadg
force-pushed
the
ta/vstorage-cli
branch
from
19fb806 to
5bf7d83
Compare
michaelfig
approved these changes
Dec 15, 2023
turadg
force-pushed
the
ta/vstorage-cli
branch
from
5bf7d83 to
d979358
Compare
mhofman
pushed a commit
that referenced
this pull request
Feb 18, 2024
feat: agd query vstorage trailing slash for children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I find myself using
agd query vstorageby descending paths and sometimes querying data. Having to go back to the command to changedatavs children` is a bit cumbersome.This adds a
pathcommand that queries children if there's a trailing dot and data otherwise. This maintains backwards compatibility with the extant commands for each.Future work could be to add an option to recursively query down the tree.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations
Backwards compatible. Though the recursive option might change the output. Maybe I should change it now to handle that case?