6184 wallet.current record #6359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
6184-wallet-current
branch
2 times, most recently
from
eb33d67 to
4d97f9c
Compare
dckc
approved these changes
Sep 30, 2022
| ); | ||
| t.deepEqual(Object.keys(currentState.offerToUsedInvitation), ['44']); | ||
| t.is( | ||
| currentState.offerToUsedInvitation[44].value[0].description, |
| @@ -47,7 +47,7 @@ agd query bank balances "$WALLET_BECH32" | grep ubld || exit 1 | |||
| echo "Provisioning your smart wallet..." | |||
| agoric wallet provision --spend --account "$WALLET" | |||
| echo "waiting for blocks" | |||
| sleep 5 | |||
| sleep 10 | |||
| const latest = await iterator.next(); | ||
| /** @type {import('@agoric/smart-wallet/src/smartWallet').CurrentWalletRecord} */ | ||
| const current = latest.value.value; | ||
| console.log('fetcHCurrent', current); |
There was a problem hiding this comment.
Looks drafty. Did you mean to keep that?
Not critical.
michaelfig
reviewed
Sep 30, 2022
| console.log('fetchCurrent()'); | ||
| const latestIterable = await E(currentFollower).getLatestIterable(); | ||
| const iterator = latestIterable[Symbol.asyncIterator](); | ||
| const latest = await iterator.next(); |
There was a problem hiding this comment.
To prevent a race between the two followers, we need to store the height at which latest was published, like the way we used to get from getFirstHeight.
michaelfig
reviewed
Sep 30, 2022
| } | ||
| console.log('brandToPurse map', brandToPurse); | ||
| updatePurses(); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| }; | |
| return firstHeight; | |
| }; |
michaelfig
reviewed
Sep 30, 2022
Comment on lines
208
to
210
| const followLatest = async () => { | ||
| console.log('followLatest()'); | ||
| for await (const { value } of iterateEach(updateFollower)) { |
There was a problem hiding this comment.
Suggested change
| const followLatest = async () => { | |
| console.log('followLatest()'); | |
| for await (const { value } of iterateEach(updateFollower)) { | |
| const followLatest = async firstHeight => { | |
| console.log('followLatest()'); | |
| for await (const { value } of iterateEach(updateFollower, { height: firstHeight })) { |
michaelfig
approved these changes
Sep 30, 2022
|
Since this has on-chain changes, it needs to go on the release-pismo branch, one way or the other. |
turadg
force-pushed
the
6184-wallet-current
branch
from
4d97f9c to
8e94f86
Compare
turadg
force-pushed
the
6184-wallet-current
branch
from
8e94f86 to
fa3e4e6
Compare
turadg
force-pushed
the
6184-wallet-current
branch
from
fa3e4e6 to
4c6544b
Compare
I tried to make this PR base of release-pismo but it has diverged enough from master that the rebase was somewhat cumbersome. I'll wait for this to get into master and then do a separate PR to get the commits into pismo. |
turadg
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6184 (partial)
Description
Add a
.currentsubnode to the wallet node for clients to have a stable HEAD that has all precious state. This is a slow growing set so won't bring on the problems of #6038The keys are,
Also updates wallet CLI and GUI to use it.
Security Considerations
Nothing exposed that wasn't published before in some fashion.
Documentation Considerations
--
Testing Considerations
PSM integration test covers it. It would be good to have more specific tests but not economical right now.
Manually tested
agoric wallet showand that Wallet UI shows the purse balances.