Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Ava to 4 #4727

Conversation

turadg
Copy link
Member

@turadg turadg commented Mar 3, 2022

closes: #4722

Will be merged by squash.

Description

This upgrades Ava to version 4 (release notes).

Merging this will solve #4722. Example launch config:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "type": "pwa-node",
            "request": "launch",
            "name": "Debug AVA test file",
            "runtimeExecutable": "${workspaceFolder}/node_modules/.bin/ava",
            "runtimeArgs": [
              "${file}"
            ],
            "outputCapture": "std",
            "skipFiles": [
                "<node_internals>/**"
            ],
        }
    ]
}

However there are some outstanding hurdles:

Security Considerations

--

Documentation Considerations

Launch config should be added to #4418

Testing Considerations

Tested locally that the launch config works.

@turadg turadg linked an issue Mar 3, 2022 that may be closed by this pull request
@turadg turadg marked this pull request as draft March 3, 2022 15:00
@turadg turadg force-pushed the 4722-ability-to-use-debug-ava-tests-with-a-launch-configuration branch from fa661db to c2aa760 Compare March 3, 2022 15:41
@turadg turadg mentioned this pull request Mar 22, 2022
@turadg
Copy link
Member Author

turadg commented Mar 22, 2022

Motivating problem solved. Punting Ava 4 upgrade to #4895

@turadg turadg closed this Mar 22, 2022
@turadg turadg deleted the 4722-ability-to-use-debug-ava-tests-with-a-launch-configuration branch April 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use debug AVA tests with a launch configuration
1 participant