SwingSet: Consolidate kernel run queue syscalls #4593
Conversation
| * @param {string} kref Target of the message | ||
| * @param {string} method The message verb | ||
| * @param {*} args The message arguments | ||
| * @param {ResolutionPolicy=} policy How the kernel should handle an eventual |
There was a problem hiding this comment.
@warner, this method had a duplicate JSDoc depending on where you grabbed it from. I carried the stricter type of ResolutionPolicy here, but that causes a type error on line 105 below (if (policy !== 'none')), since 'none' is not a valid ResolutionPolicy.
There was a problem hiding this comment.
Hm, I think that comparison should have been sendOnly. But grepping for queueToKref in test/, I see a whole lot of 'none' getting used, and no sendOnly.
Could you try replacing sendOnly with none in the type definition (and docs), and see if the tests all pass? If so, 'none' it is.
| * @param {string} kref Target of the message | ||
| * @param {string} method The message verb | ||
| * @param {*} args The message arguments | ||
| * @param {ResolutionPolicy=} policy How the kernel should handle an eventual |
There was a problem hiding this comment.
Hm, I think that comparison should have been sendOnly. But grepping for queueToKref in test/, I see a whole lot of 'none' getting used, and no sendOnly.
Could you try replacing sendOnly with none in the type definition (and docs), and see if the tests all pass? If so, 'none' it is.
That was it! |
mhofman
force-pushed
the
mhofman/4542-syscall-refactor
branch
from
81bfb53 to
a03e508
Compare
Description
This change is preliminary refactor before #4542 and #3465, and just moves some code around. The goal is to consolidate the implementation of syscalls that impact the run queue into a single place. After this I believe all operations that result in a message to be added to the run queue transit through one of the methods of
kernelQueue.js, except for thecreate-vatmessage.Security Considerations
None
Documentation Considerations
N/A
Testing Considerations
Since this only moves code, no tests are added or removed, and all tests pass.