Fix IBC (x/capability) nondeterminism after node restart
#4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
added
cosmic-swingset
michaelfig
changed the title
x/capability) nondeterminism after node restart
File a new issue? Is this something we can extend the loadgen to do? |
dckc
approved these changes
Dec 9, 2021
| @@ -5,6 +5,8 @@ export const CENTRAL_DENOM = 'urun'; | |||
| export const MINT_DENOM = 'ubld'; | |||
| export const STAKING_DENOM = 'ubld'; | |||
| export const STAKING_MAX_VALIDATORS = 150; | |||
| export const COSMOS_TRANSFER_PORT_ID = 'cosmos-transfer'; | |||
There was a problem hiding this comment.
I'm still fuzzy on transfer vs. cosmos-transfer. Is it worth adding a comment about that here?
JimLarson
approved these changes
Dec 9, 2021
michaelfig
force-pushed
the
mfig-dont-munge-genesis
branch
from
f05ba9a to
823f4fe
Compare
michaelfig
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4159
Description
Fixes nondeterminism caused by missing
x/capabilityin the CosmosSetOrderBeginBlockerscall (found by narrowing down to ax/capabilityproblem, then studying occurrences ofcapabilityin Cosmos SDK v0.44.4cosmos-sdk/simapp/app.go).Simplifies the
golang/cosmos/app/app.goto set lessgenesis.jsonoverrides, instead doing it explicitly inagoric set-defaults. This makes things a little less magical.Also updates
packages/deploymentto work with newer Docker installations where the/sys/fs/cgroupmust not be mounted. I needed this to do local testing.Security Considerations
Documentation Considerations
Testing Considerations
We really need multinode IBC testing along with the other loadgen tests. Maybe for the New Year?