Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A liberal sprinkling of type: module #1367

Closed
wants to merge 1 commit into from
Closed

Conversation

kriskowal
Copy link
Member

This change adds "type": "module" to various package.json files per the newish Node.js convention for declaring the intended format of .js files. Although -r esm does not appear to need this it is "proper" and will help Endo.

This change adds `"type": "module"` to various `package.json` files per the newish Node.js convention for declaring the intended format of `.js` files. Although `-r esm` does not appear to need this it is "proper" and will help Endo.
@kriskowal kriskowal requested a review from katelynsills August 4, 2020 22:58
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine to me. I'd rather not merge without tests passing, and it seems be related to the bundling

@kriskowal
Copy link
Member Author

Oh, my. This looks like an argument between -r esm and ESM. Investigating.

@kriskowal
Copy link
Member Author

kriskowal commented Aug 4, 2020

I’ve tread over a landmine. Stepping away slowly. #527 (comment)

I think I can invent a convention that will allow Endo to bridge ESM/RESM codebases, using a higher-precedence package.json configuration that only it recognizes, like {"parsers": {"js": "mjs"}} or something similar. Might even be able to hint at a future where another package can provide parsers, like {"parsers": {"html": "gutentags/html"}, "devDependencies": {"gutentags": "^2.0.0"}}.

@kriskowal kriskowal closed this Aug 4, 2020
@kriskowal kriskowal deleted the kris/module branch August 4, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants