Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eroterest.name #71758

Closed
adguard-bot opened this issue Jan 6, 2021 · 18 comments
Closed

eroterest.name #71758

adguard-bot opened this issue Jan 6, 2021 · 18 comments
Labels

Comments

@adguard-bot
Copy link

Issue URL (Ads)

[NSFW] https://eroterest.name

Comment

Big find!

Click any video below and redirect will happen (it should open a new tab for the video but the previous page will redirect)

Right click anywhere and a warning shows up (on Firefox).

Ads are on the right side, 2 "messages" pictures will slide down and the image below them is a fake video, it leads to an ad.

After clicking any on video, ad gifs are below the video.

Clone sites: (all have the same problems)
https://xxxhamster.net
https://beegsexxx.com/
https://loboclick.me
https://youngsextube.xxx
https://mamisamateur.com/
https://grahamwoolnough.com/
https://tubedupe.mobi/
https://watchingbas.com
https://nudeq.com/
https://redhottube.me
https://xxxbrutalclips.com/
https://asyalipornosu.com

[NSFW] Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
Platform: uBlock Origin
Browser: Firefox
Filters: Ad Blocking:
AdGuard Base,
EasyList

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances
bogachenko added a commit to bogachenko/fuckfuckadblock that referenced this issue Jan 6, 2021
bogachenko added a commit to bogachenko/fuckfuckadblock that referenced this issue Jan 6, 2021
Yuki2718 added a commit to uBlockOrigin/uAssets that referenced this issue Jan 6, 2021
@Yuki2718
Copy link
Collaborator

Yuki2718 commented Jan 6, 2021

Bunch of trash sites. I didn't see ads, but if you see eroterest.name#%#//scriptlet("abort-on-property-read", "document.dispatchEvent") might help.

Yuki2718 added a commit to uBlockOrigin/uAssets that referenced this issue Jan 7, 2021
@garry-ut99
Copy link

garry-ut99 commented Apr 18, 2021

@Yuki2718

it's about to cover comments 2, 3 and 5 in uBlock (unless you want to cover comment 1 in uBlock as well)

@Yuki2718
Copy link
Collaborator

@garry-ut99 Will be fixed as long as our time allows, but the linked issue looks to be, TBH, kinda "TL; DR" thing. I'll check later.

@garry-ut99
Copy link

The guy who created the whole issue spent much time and effort:

  • finding and collecting all the pornsites
  • creatiing filters to hide the ads
  • creating all the issue / comments and keeping them well formatted
  • providing much information and description what the issue is about
  • and while doing all of this, he actually put it as short as possible, not his fault there is so many such kind of websites...
  • waiting patiently many weeks / months until one take care of fixing the websites

Confirmation of this is this guy's a appreciative comment: easylist/easylist#5391 (comment)

Therefore labeling it:

Yuki2718 : the linked issue looks to be, TBH, kinda "TL; DR" thing

Is kinda a disrespectful reply, as the guy who created the issue deserves to his work be rather appreciated (even if declined to be fixed), not stupidly disrespectfuly labeled by an internet slang: https://www.quora.com/Is-the-TL-DR-designation-incredibly-rude-lazy-and-pretentious-Its-as-if-the-onus-is-being-put-on-the-writer-instead-of-the-reader

"If an answer is too much for you to process, go read a different answer. Announcement of your short attention span is of no interest to anyone."

@Yuki2718
Copy link
Collaborator

@garry-ut99 It's not my intention to disregard/disrespect the issue, the thing is all of uAssets maintainer are volunteers spending spare time for no money. Even in ad-blocking staff only I have many other tasks pending and I have to assign some priority just by looking at an issue.

@Yuki2718
Copy link
Collaborator

Yuki2718 commented Apr 18, 2021

Fixed all by generic filters: uBlockOrigin/uAssets@da6f358
I ignore Latest updates on other mature porn tubes title leftover, it's not serious and trying to hide this has risk of false positive. I wonder if they can be added to AG (replace the old fixes), @Alex-302

@Alex-302
Copy link
Member

I don't want to add the rules for porn farms. Especially general, without domain restrictions.

@Yuki2718 uBlockOrigin/uAssets@da6f358#diff-4c4f42122f8aa0b951dfae2559543e589a1cb85689c53cd93601d7fafb67b321R2566 it may be dangerous.

@Yuki2718
Copy link
Collaborator

@Alex-302 Okay, will temporary comment out and adjust later.

@garry-ut99
Copy link

garry-ut99 commented Apr 19, 2021

Yuki2718 : #71758 (comment)

I was supposing so, as I'm not so stupid, despite it, watch your dictionary, not everyone like it nor is interested in guessing someone's intentions, nor has time for it, and still, someone may misguess someone's intentions anyway, besides, it's not only about intentions, using such vocabulary is abusive itself regardless of good intentions.

Alex-302 : #71758 (comment) : it may be dangerous.

@Yuki2718
Copy link
Collaborator

@garry-ut99 Okay, I admit I often don't understand implications of those English slung. Having searched, I found "TL; DR" indeed can include negative nuance. My apology.
I already changed #reclama to more specific form - it's less efficient but still better than com###reclama which is injected unconditionally on all .com sites.

@garry-ut99
Copy link

garry-ut99 commented Apr 19, 2021

Alex-302 : #71758 (comment) : it may be dangerous.

I don't understand all this "it may be dangerous." drama and creating more complicated equivalents of it.

There is a very similiar filter already on EasyList: ###reklama and it covers over 4443 websites
https://publicwww.com/websites/%22id%3D%5C%22reklama%5C%22%22/
And there is only a single unbreak for it: mmgastro.pl#@##reklama

Almost identical proposed filtr ###reclama covers only 258 websites
https://publicwww.com/websites/%22id%3D%5C%22reclama%5C%22%22/
which mathematically with same statistics would give 0 breaks out of 258 websites
It can be further limited to net,com###reclama to cover lets say 100 pornsites.

What's the problem @Alex-302? Any explanation why "it may be dangerous." compared to similiar filter which is already on EasyList?

████████████████████████████████████████████████████████████████████████

Yuki2718 : #71758 (comment) : I already changed #reclama to more specific form - it's less efficient but still better than com###reclama which is injected unconditionally on all .com sites.

Generic, specific, specific-generic, conditionally, unconditionally...:

I read all the above but still has doubts, I just got lost due to all of this...
And what about these, are they specific, generic, or specific-generic? conditionally/unconditionally?:
-~ru###reclama
-~ru,###reclama (<== I heard this one is only valid on uBO Legacy)
-~ru,*###reclama

Theoretically they meet *.### criteria to be not generic anymore, so they seem to be specific-generic and thus to be unconditionally because they have something at the left side, but I'm not sure...

@Yuki2718
Copy link
Collaborator

Please ask in uBO sub reddit. I only say ~ru###reclama is a generic cosmetic filter.

@garry-ut99
Copy link

garry-ut99 commented Apr 20, 2021

By this definition:

gwarser : uBlockOrigin/uBlock-issues#803 (comment) : ABP injects all cosmetic filters unconditionally (AFAIK). uBO injects only specific filters. For generic filters, DOM is scanned and only matching ones are injected. Here Shadow DOM is interfering.

and by this as well: https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#specific-generic

we can summary comsetic filters are injected as follow:

  • generic: conditionally
  • specific: unconditionally
  • specific-generic: unconditionally

Then your answer:

Yuki2718 : ~ru###reclama a is a generic cosmetic filter.

would mean that ~ru###reclama is injected conditionally, just like ###reclama

Yuki2718 : Please ask in uBO sub reddit.

Why don't you ask yourself, I'm not a servant nor a filter maintentainer here, your friend wrote "it may be dangerous." without provoding any evidence nor explanation, this way I can say 2+2=5 or Earth is flat, then you just believed it, without asking for any evidence or explanation, and created some complicated replacement for the filter, please guys now go solve your filter-related problems yourselves. I'm currently awaiting a reply from Alex-302 as for #71758 (comment), if he will be kind to provide an answer, maybe I will be then kind to ask further on uBO sub reddit.

@wout-codes
Copy link
Contributor

Chill guys. @Yuki2718 I think it's better for you to read the report thoroughly, and then come up with a conclusion or something to comment. I suggest you to read the report again, then address, whatever is needed to be fixed. There are people who takes everything seriously. It can offend them and can lead to arguments or rudeness.

@wout-codes
Copy link
Contributor

I don't think this is ###reclama dangerous. It is mostly used in Polish websites. @Alex-302 What makes it dangerous?

@Yuki2718
Copy link
Collaborator

All the issues are already fixed.

@wout-codes
Copy link
Contributor

Then why the argument?

@garry-ut99
Copy link

garry-ut99 commented Apr 20, 2021

████████████████████████████████████████████████████████████████████████

(Personal off-topic, not started by me, I'm one of persons being adressed and accused here by wout-codes..., so I have a right to defend myself and reply)

wout-codes : #71758 (comment) : Chill guys.

I don't know what is your problem, but as for me, I'm chill, just discussing, so maybe better chill yourself or take a dog and go a walk, because as far I see nothing bad is going on here... why accusing then...maybe you overreacting...

wout-codes : #71758 (comment) : There are people who takes everything seriously.

It seems you are the perfect example of such person, we are just discussing, nothing bad is going on, really... so why are you taking it so serioulsy.

wout-codes : #71758 (comment) :
It can offend them and can lead to arguments or rudeness.

Yeah, your accusations / imagination, not followed by argumentation / examples are rude, I agree, you projected.
Otherwise please quote comments, sentences, words of your problem, otherwsie I don't know what are you even talking about...please stop calling names. Chill.

████████████████████████████████████████████████████████████████████████

Yuki2718 : #71758 (comment) :
Please ask in uBO sub reddit. I only say ~ru###reclama is a generic cosmetic filter, thus is injectec conditionally, just like ###reclama.

So it has been asked and the reply confirms that ~ru###reclama is a generic cosmetic filter:
https://www.reddit.com/r/uBlockOrigin/comments/munuor/is_rureclama_a_generic_or_a_specificgeneric_ubo/gv6sz4u?utm_source=share&utm_medium=web2x&context=3

Which means that we can use it, instead of previoulsy proposed net,com###reclama, and instead of recently added:

##center > #main > div[style^="clear:"][style$="both;"] + #reclama
##table.shemales + #reclama

no need to use complicated replacements like above as:

  • they are more complicated, longer
  • they are 2 two filters insteaf od 1
  • they are harder to maintain
  • "Yuki2718 : it's less efficient" than ~ru###reclama.

Further, we could enhance ~ru###reclama to ~ru,~ro,~ua###reclama, this way the filter will cover only about ~100 websites (as the pornsties to cover are com and net only):

screenshoot

1

lowering possibility of hypotetical "Alex-302 : dangerous" as per #71758 (comment)

wout-codes : #71758 (comment) :
I don't think this is ###reclama dangerous.

I agree, especially after enhancing the filter further to ~ru,~ro,~ua###reclama, very safe.

wout-codes : #71758 (comment) :
It is mostly used in Polish websites.

However, I can't agree to "Polish websites" part, as there is no single .pl website listed in publicwww (see the screenshoot spoiler), but it doesn't make any difference anyway.

wout-codes : #71758 (comment) : Then why the argument?

Yeah, the Yuki's argument (#71758 (comment)) against net,com###reclama was valid but it is not valid anymore against ~ru,~ro,~ua###reclama, unless Yuki or Alex have a new argument for keeping Yuki's solution over a new ~ru,~ro,~ua###reclama.

Finally, regardless of which solution will be finally chossen (the old or the new), I'll be fine with any solution which just works, I'm not here to fight or to force which solution filter maintentainers have to use, it's finally their choice, but yeah, if there was an argument provided to use the old solution, and the argument is not valid anymore, it would be nice to know why by the same reasoning to not accept the new arguments and why to not use the new solution.

@AdguardTeam AdguardTeam locked as too heated and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants