Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP issue on macOS on 0.107.28 #5712

Closed
3 tasks done
kour1er opened this issue Apr 12, 2023 · 8 comments
Closed
3 tasks done

DHCP issue on macOS on 0.107.28 #5712

kour1er opened this issue Apr 12, 2023 · 8 comments
Assignees
@EugeneOne1
Labels
bug compatibility P2: High
Milestone
v0.107.29

Comments

@kour1er
Copy link

kour1er commented Apr 12, 2023

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

macOS (aka Darwin)

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.107.28

Description

I updated to v0.107.28 and DHCP seemed to stop working. This is with AdGuard Home running on a mac and working in an iOS and mac environment.

I rolled back to v0.107.27 and DHCP instantly started working again. Has anyone else seen this issue?
@EugeneOne1
Copy link
Member

@kour1er, hello and thanks for the report. Could you please collect the verbose log for us? It'd be really helpful for troubleshooting the issue. You may send it to [email protected] with the issue number in the subject.

@EugeneOne1 EugeneOne1 added the waiting for data Waiting for users to provide more data. label Apr 12, 2023
@kour1er
Copy link
Author

kour1er commented Apr 13, 2023

So I just put build 0.107.28 in verbose mode and this immediately jumped out:

`2023/04/13 16:16:25.122279 57486#34 [debug] dhcpv4: starting...

2023/04/13 16:16:25.122587 57486#34 [debug] dhcpv4: setting secondary dns ip to itself

2023/04/13 16:16:25.122662 57486#34 [debug] dhcpv4: got addresses [10.0.0.3 10.0.0.3] after 0 attempts

2023/04/13 16:16:25.122801 57486#34 [error] starting dhcp server: dhcpv4: creating raw udp connection: listen packet 00:3e:e1:c4:3b:eb: packet: not implemented on darwin
`

Might that be the issue?

@ainar-g ainar-g added bug P2: High compatibility and removed waiting for data Waiting for users to provide more data. labels Apr 13, 2023
@ainar-g ainar-g added this to the v0.107.29 milestone Apr 13, 2023
adguard pushed a commit that referenced this issue Apr 14, 2023
@EugeneOne1
Pull request 1830: 5712-rollback-dhcp
6d402dc 
Merge in DNS/adguard-home from 5712-rollback-dhcp to master

Updates #5712.

Squashed commit of the following:

commit 3d53a63
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 14 16:30:18 2023 +0300

    dhcpd: imp import

commit 86bd55b
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 14 16:26:41 2023 +0300

    all: return todo

commit 629c548
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 14 16:24:10 2023 +0300

    all: log changes

commit e4c369e
Author: Eugene Burkov <[email protected]>
Date:   Fri Apr 14 16:03:03 2023 +0300

    dhcpd: revert raw for darwin
@EugeneOne1
Copy link
Member

@kour1er, we've just rolled back the dependency, which caused the MacOS support for raw DHCP broadcasting disappear. Could you please try the latest edge build?

@kour1er
Copy link
Author

kour1er commented Apr 14, 2023

Thanks for looking into this - just installed v0.108.0-a.529+6d402dc8 and seems to be working as expected!

@EugeneOne1
Copy link
Member

@kour1er, thanks for testing. Closing for now.

@ainar-g ainar-g changed the title DHCP issue on 0.107.28 DHCP issue on macOS on 0.107.28 Apr 18, 2023
@ainar-g ainar-g mentioned this issue Apr 18, 2023
Closed
3 tasks
@ainar-g ainar-g modified the milestones: v0.107.30, v0.107.29 Apr 18, 2023
@thirstyice
Copy link

thirstyice commented May 13, 2023 •
edited
Loading

It seems that I'm having the same issue on freebsd on v0.107.29
Here's the text of the error I get in the ui:
Error: control/dhcp/set_config | enabling dhcp: starting dhcp server: dhcpv4: creating raw udp connection: listen packet 1e:66:6d:a2:f8:fc: packet: not implemented on freebsd | 400

Edit: Error is not present on v0.107.22

@Gobd
Copy link
Contributor

Gobd commented May 18, 2023

@ainar-g I had a PR to remove the raw dep from the dhcp package as well. I closed it once this issue was discovered but it got merged anyways. You might want to go back one commit in your dhcp version from this change: b72a3d0

https://github.com/insomniacslk/dhcp/commits/49801966e6cb

@EugeneOne1
Copy link
Member

@Gobd, it seems, the update is only related to the github.com/insomniacslk/dhcp/dhcpv4/nclient4 package, which is used in our Linux-specific code and should work as intended. We didn't notice any DHCP malfunctioning on macOS so far, however, we'll monitor any related issues. Thank you for your concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug compatibility P2: High
Projects
None yet
Milestone
v0.107.29
Development

No branches or pull requests
5 participants
@Gobd @ainar-g @thirstyice @kour1er @EugeneOne1