Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Acode ignoring main, readme and icon fields in plugin manifest #1085

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alMukaafih
Copy link
Contributor

Fix to Acode Ignoring main, readme and icon fields in plugin manifest (#1026)

@bajrangCoder
Copy link
Collaborator

It fails to load existing plugins

@alMukaafih
Copy link
Contributor Author

It fails to load existing plugins

I will look into it

@bajrangCoder bajrangCoder marked this pull request as draft December 2, 2024 02:56
@bajrangCoder
Copy link
Collaborator

bajrangCoder commented Dec 6, 2024

I think problem is in plugin templates , as it points to main: "dist/main.js" but in zip file it's not in dist folder .

So handle this as legacy one

@alMukaafih
Copy link
Contributor Author

I think problem is in plugin templates , as it points to main: "dist/main.js" but in zip file it's not in dist folder .

So handle this as legacy one

I noticed this issue too. That is why I was testing for the existence of pluginJson.main before defaulting to "main.js" but it seems something went wrong somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants