Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework author noting inherent mock and stagelight config #834

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

girazoki
Copy link
Contributor

@girazoki girazoki commented Oct 7, 2024

This PR moves the mock of author noting before the kick_off_authorship inherent checks. We have a new chain in which we only run the author noting inherent but not the kick_off_authorship inherent, which would fail before this PR. This should not affect any of the other chains as we are only mocking the storage that verifies on_finalize that the inherent has run.

Additionally, I added a new config for the new chain, which we are calling stagelight. this is for now just the stagenet version of a testnet that will be launched in a couple of weeks, once we launch it I will make a PR putting the testnet config file

Copy link
Collaborator

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be some check so we don't create a storage change for other chains. I suggest leaving current implementation untouched and do this inside return []

@girazoki
Copy link
Contributor Author

girazoki commented Oct 8, 2024

There needs to be some check so we don't create a storage change for other chains. I suggest leaving current implementation untouched and do this inside return []

I can check if the pallet exists before doing the storage change, would that be ok?

@girazoki
Copy link
Contributor Author

girazoki commented Oct 8, 2024

@ermalkaleci is the CI test failing because of this changes? I dont see anythng where I could have affected it

@ermalkaleci
Copy link
Collaborator

@ermalkaleci is the CI test failing because of this changes? I dont see anythng where I could have affected it

no, it's RPC timed out

@xlc xlc merged commit 81066ea into AcalaNetwork:master Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants