-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework author noting inherent mock and stagelight config #834
Rework author noting inherent mock and stagelight config #834
Conversation
packages/core/src/blockchain/inherent/parachain/nimbus-author-inherent.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be some check so we don't create a storage change for other chains. I suggest leaving current implementation untouched and do this inside return []
I can check if the pallet exists before doing the storage change, would that be ok? |
packages/core/src/blockchain/inherent/parachain/nimbus-author-inherent.ts
Show resolved
Hide resolved
@ermalkaleci is the CI test failing because of this changes? I dont see anythng where I could have affected it |
no, it's RPC timed out |
This PR moves the mock of
author noting
before thekick_off_authorship
inherent checks. We have a new chain in which we only run the author noting inherent but not thekick_off_authorship
inherent, which would fail before this PR. This should not affect any of the other chains as we are only mocking the storage that verifies on_finalize that the inherent has run.Additionally, I added a new config for the new chain, which we are calling stagelight. this is for now just the stagenet version of a testnet that will be launched in a couple of weeks, once we launch it I will make a PR putting the testnet config file