Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no auto block in manual mode #818

Merged
merged 2 commits into from
Sep 4, 2024
Merged

no auto block in manual mode #818

merged 2 commits into from
Sep 4, 2024

Conversation

xlc
Copy link
Member

@xlc xlc commented Sep 4, 2024

when block building mode is manual, it should be manual

@xlc xlc requested a review from ermalkaleci September 4, 2024 03:57
@xlc
Copy link
Member Author

xlc commented Sep 4, 2024

@ermalkaleci Moonbeam and Astar is currently always having messageQueue.bookStateFor(Parent) so unconditionally builds extra block when received messages and that breaks e2e tests. Not sure why that is happening but this will be an easy fix to get the e2e tests working with some tweaks

@ermalkaleci
Copy link
Collaborator

ermalkaleci commented Sep 4, 2024

@ermalkaleci
Copy link
Collaborator

We have this for Parent, I don't know if it's a bug or not. Chopsticks will check the size which is gt 0 and build although we handle queued messages on idle

[
      Parent
]
{
      begin: 57
      end: 57
      count: 1
      readyNeighbours: null
      messageCount: 1
      size_: 11
 }

@ermalkaleci
Copy link
Collaborator

@xlc I think rather than disabled it on manual mode ( I think it should cause other problems), we instead check end > begin. I will solve current issue

@xlc
Copy link
Member Author

xlc commented Sep 4, 2024

@xlc I think rather than disabled it on manual mode ( I think it should cause other problems), we instead check end > begin. I will solve current issue

that will be better. you want to make a PR?

@ermalkaleci
Copy link
Collaborator

@xlc you can just update this one

@xlc xlc enabled auto-merge (squash) September 4, 2024 04:39
@xlc xlc merged commit 462f6c2 into master Sep 4, 2024
6 checks passed
@xlc xlc deleted the fix-auto-block branch September 4, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants