make json-rpc server id handling spec-compliant #807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial bit of work for #801
This makes id handling spec-compliant by JSON-RPC 2.0. Notable changes:
id
can now be parsed as a number, string, null or undefinedid
is a number, it must be an integer.id
from error responses is now correct:null
.id
is undefined, no response is returned.I couldn't find a good place to add tests for these cases - please let me know if you want me to add some, or if you need anything else.I could find the test file,
e2e/src/http.test.ts