Fixed a redeem bug and added more Homa lite tests #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 16, 2021 18:32
…c model more easily for HomaLite Added basic unit tests using the feeless mock.
…ailable-staking-balances Added more tests and modified existing tests
xlc
reviewed
Nov 18, 2021
added 2 commits
November 18, 2021 19:25
…alance, mint/adjust_available_staking_balance will not fail, and will skip the request instead Added corresponding unit test.
wangjj9219
approved these changes
Nov 18, 2021
syan095
pushed a commit
that referenced
this pull request
Nov 20, 2021
…edeem-match * origin/master: Add more test cases (#1620) bump (#1622) update protocolId and bootnode Fixed a redeem bug and added more Homa lite tests (#1619) Add module asset registry (#1598) MaxAuctions count to 50 (#1617) Cdp Treasury Bench update (#1609) Bump @openzeppelin/contracts from 4.3.2 to 4.3.3 in /ts-tests (#1612) # Conflicts: # modules/homa-lite/src/lib.rs # modules/homa-lite/src/tests_no_fees.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where when redeeming with available staking balance the staking total is not updated
Refactored the code so all redeem logic shares the same code
Added a new mock that have no fees to test economic model
Added tests to ensure that when no fees are charged, the exchange rate says the same throughout all operations.
Modified
RedeemRequestedevent to include the fee being charged.