openvdb/python/CMakeLists.txt: Minor fix and CMake v3.11 compatibility #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracwyrm
force-pushed
the
python-fixes
branch
2 times, most recently
from
4523b37 to
1481996
Compare
Adding the python version string to finding the python module of Boost fixes this error: CMake Error at /.../FindBoost.cmake:2044 Remove unneeded python version variables as PythonInterp already defines them. PYOPENVDB_INSTALL_DIRECTORY variable cannot be set during configure phase because it is hard set. Test if it is not defined before setting it to a default. Signed-off-by: Jonathan Scruggs <[email protected]>
|
How come all tests passed except this one? |
Just some random network timeout. It reran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the python version string to finding the python module of
Boost fixes this error: CMake Error at /.../FindBoost.cmake:2044
More on the error here: https://bugs.gentoo.org/652266
Remove unneeded python version variables as PythonInterp already
defines them.
PYOPENVDB_INSTALL_DIRECTORY variable cannot be set during configure
phase because it is hard set. Test if it is not defined before
setting it to a default.
Signed-off by: Jonathan Scruggs [email protected]