-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added read/write support of OFF files to vdb_tool #1971
Merged
kmuseth
merged 20 commits into
AcademySoftwareFoundation:master
from
kmuseth:improve_vdb_tool
Dec 2, 2024
Merged
added read/write support of OFF files to vdb_tool #1971
kmuseth
merged 20 commits into
AcademySoftwareFoundation:master
from
kmuseth:improve_vdb_tool
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Museth <[email protected]>
kmuseth
requested review from
apradhana,
jmlait,
Idclip,
danrbailey and
richhones
as code owners
November 20, 2024 19:43
Signed-off-by: Ken Museth <[email protected]>
swahtz
reviewed
Nov 21, 2024
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
swahtz
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
…distro Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Missing iomanip include in TestNanoVDB Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Ken Museth <[email protected]>
…into improve_vdb_tool
Signed-off-by: Ken Museth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 ) Added read and write support for OFF (Object File Format) files to vdb_tool
Optimized and improved readPLY/writePLY so it can handle more cases, eg vertex coordinates in double precision
Also expanded and fixed some bugs in the unit-test