Skip to content
This repository has been archived by the owner on Apr 28, 2021. It is now read-only.

Add More Tests for Alias #237

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Add More Tests for Alias #237

merged 3 commits into from
Nov 2, 2019

Conversation

seanlowjk
Copy link

@seanlowjk seanlowjk commented Nov 1, 2019 •
edited
Loading

I have added tests for the following sections, to ensure testability and lower chance of unexpected bugs to occur.

Alias Section:
AliasPair
AliasList
AliasChecker

Storage Section:
JsonAdaptedAliasPair
JsonAliasListStorage
JsonSerializableAliasList

@seanlowjk seanlowjk changed the title [To be merged later] Add More Tests [To be merged at a later date] Add More Tests Nov 1, 2019
@seanlowjk seanlowjk added this to the v1.4 milestone Nov 1, 2019
@seanlowjk seanlowjk changed the title [To be merged at a later date] Add More Tests Add More Tests for Alias Nov 1, 2019
tanamaroby
tanamaroby approved these changes Nov 2, 2019
View reviewed changes
Copy link

@tanamaroby tanamaroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanamaroby tanamaroby merged commit d276cd8 into AY1920S1-CS2103T-F13-2:master Nov 2, 2019
@nus-se-bot nus-se-bot mentioned this pull request Nov 7, 2019
Open
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tanamaroby tanamaroby tanamaroby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlowjk @tanamaroby