Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos from recent ARM_DSP_ATTRIBUTE additions #201

Closed
renesas-kyle-finch opened this issue Jul 25, 2024 · 4 comments
Closed

Typos from recent ARM_DSP_ATTRIBUTE additions #201

renesas-kyle-finch opened this issue Jul 25, 2024 · 4 comments
Labels
bug Something isn't working DONE Issue done but not yet closed

Comments

@renesas-kyle-finch
Copy link

It appears there are some unintended insertions of the new ARM_DSP_ATTRIBUTE in front of some function parameters rather than only in front of functions.

When defining ARM_DSP_ATTRIBUTE to __WEAK for example, using IAR generates the following build error:
Error[Pe1835]: attribute "weak" does not apply here

The places I have found (so far) to have this issue are:

Source/TransformFunctions/arm_cftt_radix2_f16.c:arm_cfft_radix2_f16()
Source/TransformFunctions/arm_cftt_radix2_f32.c:arm_cfft_radix2_f32()
Source/SupportFunctions/arm_bitonic_sort_f32.c:arm_bitonic_sort_f32()
Source/FilteringFunctions/arm_fir_f32.c:arm_fir_f32()

Would it be possible for these to be fixed and a v1.16.2 be released?

@christophe0606 christophe0606 added the bug Something isn't working label Jul 26, 2024
@christophe0606
Copy link
Contributor

@renesas-kyle-finch Thanks for reporting this. I am testing with the __WEAK attribute but I am not testing with IAR. It looks like other compilers are not catching this issue.

christophe0606 added a commit that referenced this issue Jul 26, 2024
@christophe0606
Copy link
Contributor

@renesas-kyle-finch I have just pushed a fix. Tell me if it is ok before I generate the new release.

@renesas-kyle-finch
Copy link
Author

@christophe0606 Thank you for pushing a fix. It seems to have resolved the failures I was seeing before.

@christophe0606
Copy link
Contributor

@renesas-kyle-finch New pack v1.16.2 has been uploaded. It should become visible in IDEs soon.

@christophe0606 christophe0606 added the DONE Issue done but not yet closed label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DONE Issue done but not yet closed
Projects
None yet
Development

No branches or pull requests

2 participants