Refactor AverageAffineTransformFunction #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NoRigid is an important variant and at one time was the recommended default
when initializing with a reference space (eg MNI)
On Wed, Feb 28, 2024 at 12:32 PM Dženan Zukić ***@***.***> wrote:
Remove NoRigid variant, and add useRigid and verbose iVars to
AverageAffineTransformFunction.
Removal of NoRigid variant is a code simplification.
Addition of verbosity flag allows use from libraries where debug output is
not expected and undesirable.
------------------------------
You can view, comment on, or merge this pull request online at:
#1684
Commit Summary
- e9ec28e
<e9ec28e>
ENH: Refactor AverageAffineTransformFunction (remove NoRigid variant)
- 51ee305
<51ee305>
ENH: Control AverageAffineTransformFunction's verbosity via an ivar
File Changes
(5 files <https://github.com/ANTsX/ANTs/pull/1684/files>)
- *M* Examples/AverageAffineTransformNoRigid.cxx
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-be29f61ca8c2fe5f364e08bd69786fd8a33c5a305ab6cef9ec7bceec8f073b71>
(5)
- *M* Utilities/itkAverageAffineTransformFunction.h
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-7ff5df59e0c5e073eb75890bfbc5bc0fbc68487401e70d3bf71f717de802830f>
(29)
- *M* Utilities/itkAverageAffineTransformFunction.hxx
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-1b42509fc070f4d3434e0d06c405c9e4c6283f1e49fa9c4a55a95e5abce91d1c>
(159)
- *D* Utilities/itkAverageAffineTransformNoRigidFunction.h
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-ee7d8c4733454c8848f6675b47292df66cf992ea7ed2fe63e27f1703ff228fc6>
(200)
- *D* Utilities/itkAverageAffineTransformNoRigidFunction.hxx
<https://github.com/ANTsX/ANTs/pull/1684/files#diff-5989927b2ce200b19dfdd77d3cc12ccc626e4865bb10a8826502df9d29fe11cf>
(344)
Patch Links:
- https://github.com/ANTsX/ANTs/pull/1684.patch
- https://github.com/ANTsX/ANTs/pull/1684.diff
—
Reply to this email directly, view it on GitHub
<#1684>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACPE7WFUTSFX7VEVJ3N76DYV5S3FAVCNFSM6AAAAABD6OL4A6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TSNBXGUYTQMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
brian
|
|
It's functionality still exists, and has been moved to the main function: |
|
This impacts some of the template construction scripts and those would need updating. |
|
This looks like it's backwards compatible, just refactors how the "no affine" average is computed. |
|
@cookpa you are correct. Computation of |
|
@gdevenyi The executable |
|
Ok, this was unclear to me from the initial comment.
|
cookpa
reviewed
Feb 28, 2024
|
Sure, a new commit is incoming. |
Verbose is off by default in the class. Executables turn on verbosity for backwards compatibility.
dzenanz
force-pushed
the
refactorAvgAffine
branch
from
51ee305 to
911eadf
Compare
cookpa
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
NoRigidvariant, and adduseRigidandverboseiVars toAverageAffineTransformFunction.Removal of
NoRigidvariant is a code simplification.Addition of verbosity flag allows use from libraries where debug output is not expected and undesirable.