Routing Policy Tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutshkumr
reviewed
Feb 19, 2021
Rangababu-R
requested changes
Apr 1, 2021
| yield api | ||
|
|
||
| if api.assistant is not None: | ||
| api.assistant.Session.remove() |
There was a problem hiding this comment.
If this line still throws assistant attr not found exception use getattr(api, 'assistant', None) in if condition
|
Spelling issue: Rujje->Ruijie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR consists of tests to validate Routing Policies on DUT using
t0TGEN testbed. The test plan was developed by Tencent & Ruijie. The tests were developed by Keysight using SnappiType of change
Approach
What is the motivation for this PR?
Leverage the test topology “SONiC Testbed with Keysight IxNetwork as Traffic Generator” to qualify the SONiC DUT with 200G and 400G interfaces. The first batch of test cases cover the BGP routing policies over 200/400G interface.
How did you do it?
Test cases:
All the testcases are added in the test plan document with this PR
https://github.com/ANISH-GOTTAPU/sonic-mgmt/blob/fc415fdb05c41c077cf9a10c0fe7e31edb84e5e1/docs/testplan/routing_policies.md
How did you verify/test it?
Verification steps are added in the test plan document
https://github.com/ANISH-GOTTAPU/sonic-mgmt/blob/fc415fdb05c41c077cf9a10c0fe7e31edb84e5e1/docs/testplan/routing_policies.md
Supported testbed topology if it's a new test case?
t0