Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid silent preequilibration failure in JAX #2631

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

FFroehlich
Copy link
Member

fixes #2628

@FFroehlich FFroehlich requested a review from a team as a code owner December 17, 2024 10:11
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (3206fce) to head (5598c5d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2631      +/-   ##
===========================================
+ Coverage    77.03%   78.15%   +1.11%     
===========================================
  Files          332      330       -2     
  Lines        22970    21962    -1008     
  Branches      1478     1478              
===========================================
- Hits         17695    17164     -531     
+ Misses        5264     4787     -477     
  Partials        11       11              
Flag Coverage Δ
cpp 74.18% <100.00%> (+0.21%) ⬆️
cpp_python 33.46% <0.00%> (-0.01%) ⬇️
petab 38.32% <100.00%> (+<0.01%) ⬆️
python 72.59% <100.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/model.py 85.61% <100.00%> (-1.47%) ⬇️

... and 55 files with indirect coverage changes

@FFroehlich FFroehlich enabled auto-merge December 17, 2024 20:24
Copy link

sonarcloud bot commented Dec 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants