Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RDataReporting::observables_likelihood #2627

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 16, 2024

Add RDataReporting::observables_likelihood for computing observables, likelihood and the respective sensitivities. Closes #2625.

Fixes allocating ReturnData::sllh despite SensitivityMethod::none.

Add RDataReporting::observables_likelihood for computing observables, likelihood and the respective sensitivities. Closes AMICI-dev#2625.

Fixes allocating sllh despite SensitivityMethod::none.
@dweindl dweindl requested a review from a team as a code owner December 16, 2024 07:37
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (2d58f54) to head (2168938).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2627      +/-   ##
===========================================
- Coverage    77.05%   77.03%   -0.02%     
===========================================
  Files          332      332              
  Lines        22957    22970      +13     
  Branches      1477     1478       +1     
===========================================
+ Hits         17689    17695       +6     
- Misses        5257     5264       +7     
  Partials        11       11              
Flag Coverage Δ
cpp 73.96% <100.00%> (-0.02%) ⬇️
cpp_python 33.47% <7.14%> (-0.02%) ⬇️
petab 38.32% <0.00%> (-0.04%) ⬇️
python 72.12% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/rdata.h 100.00% <ø> (ø)
src/rdata.cpp 95.60% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

@dweindl dweindl added this pull request to the merge queue Dec 16, 2024
Merged via the queue into AMICI-dev:develop with commit 3206fce Dec 16, 2024
19 of 20 checks passed
@dweindl dweindl deleted the 2625_llh_obs branch December 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants