Allow using RDataReporting::residuals with ASA
#2626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2626 +/- ##
===========================================
- Coverage 77.05% 77.01% -0.04%
===========================================
Files 332 332
Lines 22957 22949 -8
Branches 1477 1475 -2
===========================================
- Hits 17689 17675 -14
- Misses 5257 5263 +6
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dweindl
force-pushed
the
2625_asa_res
branch
from
be3bc7b to
f6bc2a1
Compare
So far, it is not supported to use `RDataReporting::residuals` with ASA. However, there doesn't seem to be a good reason. It's only that the respective sensitivities for y/sigmay/res won't be computed in this case.
dweindl
force-pushed
the
2625_asa_res
branch
from
f6bc2a1 to
48bcb36
Compare
FFroehlich
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, it is not supported to use
RDataReporting::residualswith ASA. However, there doesn't seem to be a good reason.It's only that the respective sensitivities for y/sigmay/res won't be computed in this case.
Closes #2625