Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jax serialisation #2608

Merged
merged 5 commits into from
Dec 2, 2024
Merged

add jax serialisation #2608

merged 5 commits into from
Dec 2, 2024

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from a team as a code owner November 28, 2024 20:48
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (b9a3f1a) to head (2ab33c6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2608      +/-   ##
===========================================
+ Coverage    77.60%   77.78%   +0.18%     
===========================================
  Files          329      329              
  Lines        21711    21724      +13     
  Branches      1477     1477              
===========================================
+ Hits         16849    16899      +50     
+ Misses        4851     4814      -37     
  Partials        11       11              
Flag Coverage Δ
cpp 74.15% <100.00%> (+0.67%) ⬆️
cpp_python 34.13% <35.71%> (-0.01%) ⬇️
petab 36.96% <35.71%> (-0.01%) ⬇️
python 72.47% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/jax/model.py 74.71% <100.00%> (+0.29%) ⬆️
python/sdist/amici/jax/petab.py 73.17% <100.00%> (+44.59%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@FFroehlich FFroehlich merged commit 1505d90 into develop Dec 2, 2024
26 of 29 checks passed
@FFroehlich FFroehlich deleted the jax_serialisation branch December 2, 2024 12:23
Copy link

sonarcloud bot commented Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants