Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Workaround for macos segfaults #2572

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 5, 2024

Homebrew serves swig 4.3.0 which is incompatible with filterwarnings = error in pytest resulting in segfaults (#2565, swig/swig#3061).
For now, the easiest workaround seems to be just ignoring any warnings during macos runs.

@dweindl dweindl changed the title GHA: test macos-15 GHA: test macos Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.71%. Comparing base (ff6b3f1) to head (7b353a4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2572      +/-   ##
===========================================
- Coverage    77.75%   77.71%   -0.05%     
===========================================
  Files          325      325              
  Lines        21857    21857              
  Branches      1473     1473              
===========================================
- Hits         16996    16986      -10     
- Misses        4834     4844      +10     
  Partials        27       27              
Flag Coverage Δ
cpp 73.58% <ø> (-0.05%) ⬇️
cpp_python 34.20% <ø> (ø)
petab 37.07% <ø> (ø)
python 72.36% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@dweindl dweindl changed the title GHA: test macos GHA: Workaround macos segfaults Nov 5, 2024
@dweindl dweindl changed the title GHA: Workaround macos segfaults GHA: Workaround for macos segfaults Nov 5, 2024
@dweindl dweindl marked this pull request as ready for review November 5, 2024 20:04
@dweindl dweindl requested a review from a team as a code owner November 5, 2024 20:04
@dweindl
Copy link
Member Author

dweindl commented Nov 6, 2024

For now, the easiest workaround seems to be just ignoring any warnings during macos runs.

If this does not get fixed soon, we need to modify the swig-generated cpp files (base + model) to undefine SWIG_HEAPTYPES.

@dweindl dweindl merged commit 2b05a19 into AMICI-dev:develop Nov 6, 2024
19 of 20 checks passed
@dweindl dweindl deleted the gha_macos15 branch November 6, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants