PEtab: fix missing parameters in fill_in_parameters #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning/error in AMICI-dev#2444 is caused by `petab.parameters.scale()`. Whether this warning should be suppressed there or not is to discussed in the PEtab context. For amici, I'd say we're fine with just accepting `np.log(0) == -inf` without a warnings. Closes AMICI-dev#2444.
Allows providing only a subset of parameter to simulate_petab. The missing parameters are taken from nominalValues in the parameter table. Fixes AMICI-dev#2444
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2449 +/- ##
========================================
Coverage 77.64% 77.64%
========================================
Files 324 324
Lines 20928 20930 +2
Branches 1464 1464
========================================
+ Hits 16249 16251 +2
Misses 4676 4676
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows providing only a subset of parameter to simulate_petab. The missing parameters are taken from nominalValues in the parameter table.
Fixes #2444. Nevertheless, exclude
Lang_PLOSComputBiol2024to save time.