Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardise passwords; improve deployability #56

Merged
merged 1 commit into from
May 22, 2019

Conversation

linuxbandit
Copy link
Member

Changes:

  • The default password is 5ecr3t, as we decided being the default for everything
  • The .env file is used both because it's good practice AND to provide more customisation for the bootstrap of the environment (there's still room for improvement)
  • Add restart policies for containers
  • (WiP) remove HostRegexp as a condition

Copy link
Member

@serge1peshcoff serge1peshcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't break anything in theory

@@ -0,0 +1,6 @@
PATH_OMS_EVENTS=./
BASE_URL=localhost.test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it mean that we'll need to use http://localhost.test instead of http://localhost on dev machines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is that it can be set as anything one wants, so not really "need to"

of course it would be a good practice to use something that looks more like a real domain name, and the '.test' is a reserved domain from IANA, so it wont break stuff- one could use a nice tool like dnsmasq which works as local dns, see here

@serge1peshcoff
Copy link
Member

one more thing: can you update the config to use this password as default as well?

@linuxbandit
Copy link
Member Author

@serge1peshcoff you mean .env?

@linuxbandit
Copy link
Member Author

also I can't really get what fails on travis

@serge1peshcoff
Copy link
Member

Travis fails because of what I've wrote in #---development, don't worry about that.
I mean config/index.js.example, it defaults to 'postgres' once the field is not found. (also the same case for discounts and statutory)

@linuxbandit
Copy link
Member Author

it's done already ;)

@linuxbandit
Copy link
Member Author

except, didn't touch discounts :D

@linuxbandit
Copy link
Member Author

@serge1peshcoff merge when ok :)

@serge1peshcoff serge1peshcoff merged commit cae6140 into master May 22, 2019
@serge1peshcoff serge1peshcoff deleted the feat-more_standards branch May 22, 2019 21:05
@serge1peshcoff
Copy link
Member

let's see how it goes, if it'll work then I'll also update others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants