-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardise passwords; improve deployability #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't break anything in theory
@@ -0,0 +1,6 @@ | |||
PATH_OMS_EVENTS=./ | |||
BASE_URL=localhost.test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it mean that we'll need to use http://localhost.test
instead of http://localhost
on dev machines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea is that it can be set as anything one wants, so not really "need to"
of course it would be a good practice to use something that looks more like a real domain name, and the '.test' is a reserved domain from IANA, so it wont break stuff- one could use a nice tool like dnsmasq which works as local dns, see here
one more thing: can you update the config to use this password as default as well? |
@serge1peshcoff you mean .env? |
also I can't really get what fails on travis |
Travis fails because of what I've wrote in #---development, don't worry about that. |
it's done already ;) |
except, didn't touch discounts :D |
@serge1peshcoff merge when ok :) |
let's see how it goes, if it'll work then I'll also update others |
Changes: