Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema and JSON Validation CI #99

Merged
merged 3 commits into from
Sep 18, 2023
Merged

JSON Schema and JSON Validation CI #99

merged 3 commits into from
Sep 18, 2023

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Sep 18, 2023

Added *.schema.json files for validation CI. Can be done on CLI with (for example) jsonchema -i containers/compilers.json containers/compilers.schema.json.
Added build-ci CI (how meta!) for json validation.

Should close #63 !

@CodeGat CodeGat added type:feature New feature or request priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality labels Sep 18, 2023
@CodeGat CodeGat requested a review from jo-basevi September 18, 2023 00:59
@CodeGat CodeGat self-assigned this Sep 18, 2023
@CodeGat CodeGat marked this pull request as ready for review September 18, 2023 02:33
@CodeGat
Copy link
Collaborator Author

CodeGat commented Sep 18, 2023

Woah, the CI json validations checks run automatically!
image

Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Only have a small question, but it's probably fine as is 👍

containers/compilers.schema.json Outdated Show resolved Hide resolved
@CodeGat CodeGat merged commit 941d2aa into main Sep 18, 2023
3 checks passed
@CodeGat CodeGat deleted the 63-lint-json branch September 18, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/validate compilers.json
2 participants