Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ngx-whats-new to Angular v18 #1

Merged
merged 71 commits into from
Oct 28, 2024

Conversation

carriquiry-g
Copy link
Contributor

@carriquiry-g carriquiry-g commented Oct 24, 2024

New features:

  • Library updated to Angular v18
  • Accessibility and semantic improvements
  • Improved keyboard navigation
  • Close button on dialog
  • Improve component API
  • Better code readability
  • Integrated Jest
  • Changed TSLint (deprecated) for ESLint
  • Changed component to standalone (following Angular's vision)
  • Exposed interfaces on public API
  • Navigate to previous item

Things to work on:

  • Unit tests
  • Styling improvements
  • Custom theme implementations
  • Responsiveness across devices
  • Image lazy loading for content fetched from CDNs or alike

dependabot bot and others added 30 commits October 20, 2024 19:18
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.21.1.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.18.2...4.21.1)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.9)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [socket.io-parser](https://github.com/Automattic/socket.io-parser) from 4.2.2 to 4.2.4.
- [Release notes](https://github.com/Automattic/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/4.2.4/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.2.2...4.2.4)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.5.4 to 4.8.0.
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io/compare/[email protected])

---
updated-dependencies:
- dependency-name: socket.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rollup](https://github.com/rollup/rollup) from 3.10.1 to 3.29.5.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.10.1...v3.29.5)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.13 to 7.25.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.7/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@carriquiry-g
Copy link
Contributor Author

Hey @4gray, hope you are doing fine. Just wanted to let you know I found out about this Angular library looking for a what's new service implementation and this came in very handy. I noticed you hadn't updated it for a while so I took the liberty and forked it to make my own adaptations for my project.

I'll be making a hard fork from yours because of my project needs, but I wanted to update the library following a path that would be common ground for both of us. I've done this as a 'thank you' for making this public and hoping you are still using it and this update comes in handy.

Anyways, now that I've invested some time working on it, if you have plans to keep using it I would be more than happy to contribute on keeping it updated.

@carriquiry-g
Copy link
Contributor Author

Ok, I think these will be my last commits until you let me know what you think.

@4gray
Copy link
Owner

4gray commented Oct 28, 2024

Hey @carriquiry-g it looks really great, thank you for the contribution!

@4gray 4gray merged commit c726660 into 4gray:master Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants