This repository has been archived by the owner on Mar 28, 2022. It is now read-only.
Use 'exec*()' to perform client and server death tests #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benh
force-pushed
the
benh.death-tests
branch
3 times, most recently
from
ddad59c to
43f0f62
Compare
CodingCanuck
approved these changes
Feb 23, 2022
benh
force-pushed
the
benh.death-tests
branch
from
43f0f62 to
d24e495
Compare
Before this commit we tried to perform the death part of the client or server death tests in the forked child process created from 'ASSERT_DEATH()'. This has "worked" but investigating ongoing flaky tests suggests this approach is insufficient. This commit does less in the forked child by immediately doing an 'exec*()'.
benh
force-pushed
the
benh.death-tests
branch
from
d24e495 to
8fc2a02
Compare
|
PR queued successfully. Your position in queue is: 1 |
|
Branch up-to-date, waiting for checks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit we tried to perform the death part of the client or
server death tests in the forked child process created from
'ASSERT_DEATH()'. This has "worked" but investigating ongoing flaky
tests suggests this approach is insufficient. This commit does less in
the forked child by immediately doing an 'exec*()'.