submodule-sync: make fewer path assumptions
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `per-submodule-build-matrix.sh` assumed that the top level of the repo it was syncing was at `../../../../../`, which happened to be true for all of our repos. As of reboot-dev/mono@323ce51 however, that is no longer true. This commit makes the script look up the top-level of its containing repo dynamically, with its only assumption being that the script is being run from a submodule itself - which still holds. TESTED: checked that the `submodule-sync` workflow passes again for the `reboot-dev/respect` repo where it was previously broken.
onelxj
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
per-submodule-build-matrix.shassumed that the top level of the repo it was syncing was at../../../../../, which happened to be true for all of our repos. As of reboot-dev/respect@323ce51(#3786) however, that is no longer true.This commit makes the script look up the top-level of its containing repo dynamically, with its only
assumption being that the script is being run from a submodule itself - which still holds.
TESTED: checked that the
submodule-syncworkflow passes again for thereboot-dev/respectrepowhere it was previously broken.