Introduce ruff as a Python linter
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
rjhuijsman
force-pushed
the
rjh.add-ruff
branch
from
72e2ac1 to
c181344
Compare
The `ruff` linter has support for checks that some of our existing linters don't, most notably the ability to detect (and fix, if requested) unused imports. Unused imports are a cause of [many PR comments](reboot-dev/mono#2159) and wasted time. `ruff` is also a code formatter, but there's currently no strong reason to switch from `yapf` to `ruff` for that in our codebase.
rjhuijsman
force-pushed
the
rjh.add-ruff
branch
from
c181344 to
b2d3294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rufflinter has support for checks that some of our existing linters don't, most notably the ability to detect (and fix, if requested) unused imports. Unused imports are a cause of many PR comments and wasted time.ruffis also a code formatter, but there's currently no strong reason to switch fromyapftorufffor that in our codebase, so we only runruff check(linting) and notruff format(formatting).See https://github.com/reboot-dev/respect/pull/2264 for an example of fixes that
ruffprompts for.