Import rulesets from qrcode #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add capability to import rulesets from qrcode fixes and improvements
|
Thanks for your PR |
|
Yes, but for most use cases it's enough, for example the current "China Whitelist" preset has 1299 characters. (which is a mix of alpha-numeric, symbols and Chinese characters). I have successfully encoded up to 2232 characters of the same character-set. You can also encode more characters if you only use alpha-numeric characters and symbols (not using complex characters like Chinese or Persian) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capability to import rulesets from QRcode
Note: I have reused
resetRoutingRulesetsFromClipboardfunction for importing rulesets from QRcode. Therefore I've renamed this function toresetRoutingRulesetsto be more inline with it's usage. Also oldresetRoutingRulesetsfunction renamed toresetRoutingRulesetsFromPresets.