Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Propshaft to 0.9.x #11103

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Update Propshaft to 0.9.x #11103

merged 2 commits into from
Aug 16, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 16, 2024

🛠 Summary of changes

Updates the Propshaft gem to the latest version.

See release notes: https://github.com/rails/propshaft/releases

Specifically, this is aimed at addressing two things:

📜 Testing Plan

  1. Run rails assets:precompile
  2. Run rails s
  3. Go to http://localhost:3000
  4. Observe no visual defects
  5. Open developer tools Elements window
  6. Observe assets (e.g. <script> and <link> tags) have digested URLs with a hash of 8 characters (e.g.
    /packs/validated_field_component-5f68c2d7.digested.js)

aduth added 2 commits August 16, 2024 16:19
changelog: Internal, Dependencies, Update dependencies to latest versions
@aduth
Copy link
Member Author

aduth commented Aug 16, 2024

Looks good on review application as well, which I'd imagine should simulate how this'll behave in a deployed environment.

@aduth aduth merged commit e92a99f into main Aug 16, 2024
2 checks passed
@aduth aduth deleted the aduth-propshaft-0-9-0 branch August 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants