Use defer for non-critical scripts #11096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates non-critical scripts to use
defer
instead ofasync
.While both
async
anddefer
load scripts without blocking the parser,async
will block the parser to execute the script as soon as it's loaded, which may block parsing if it happens before parsing is complete.defer
will instead wait for parsing to complete before executing the script, which is acceptable behavior for the scripts affected by the changes in this pull request.The HTML specification includes helpful diagrams illustrating the difference:
Related resource: https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript#async-defer
While this resource includes analytics scripts as an example of
async
usage, it does so under the premise that these are "important for the script to run earlier in the loading process". It's not clear to me that it's important for these to run early.📜 Testing Plan
Verify there is no regression in the loading of scripts marked as
defer
, particularlytrack-errors.js
on http://localhost:3000 should load successfully in default development environments.