Fix #269 by adding setSelectedRegions function #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw - I marked this as patch rather than minor b/c the documentation implies this functionality already exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds expected setSelectedRegions function and uses it on initialization. Also updated grunt tasks to work on Windows machine, see here. Caught bower version up to npm version. Unsure if that was an intentional discrepency?
How should this be tested ?
Confirm existing tests pass (they do). I did not write a test for this particular function, however. Can be confirmed in browser by utilizing.
What are the relevant issues ?
#269 (and this StackOverflow question)
This Pull Request includes:
npm testnpm testnpm testWhat gif best describes how you feel about this work ?