This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
meshdb: Add browser support #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the browser tests are failing in CI because it can't run |
albrow
force-pushed
the
feature/meshdb-browser-support
branch
2 times, most recently
from
5be36cc to
4c545da
Compare
|
Got CI to work by apt-get installing some additional dependencies. |
fabioberger
suggested changes
Aug 3, 2019
| @@ -0,0 +1,33 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
It looks like we're not super consistent in our directory naming between using hyphens and underscores. Do we want to have a mix of both?
There was a problem hiding this comment.
Yeah we have been inconsistent here. Part of the problem is that there is an unofficial Go convention of using hyphens, but we also have things like node_modules/ which is using underscores.
How about we use hyphens for directory names whenever possible?
fabioberger
approved these changes
Aug 6, 2019
albrow
force-pushed
the
feature/meshdb-browser-support
branch
from
32312e3 to
0bc35fa
Compare
albrow
force-pushed
the
feature/meshdb-browser-support
branch
from
0bc35fa to
e06331f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full browser support for the
meshdbpackage (and thedbpackage, which it depends on). Fixes #297.I've also added a new test which uses QUnit bindings. The test is compiled to WebAssembly and run in a headless browser as part of
go test. We might be able to clean up and simplify the process in the future (e.g. by using a tool which automatically builds the required index.html file instead of checking it into git), but it should be good enough for now.I think our testing strategy should be to run all unit tests in Node.js because it's easier and allows us to use the same test files we already have (any file ending in
_test.go). We only need to run high-level integration tests in the browserThis depends on two external PRs. I modified our Gopkg.toml file to pull from our forks while we are waiting for these PRs to be merged.
goleveldbpacakge.norunners/vertpackage, which we are using to help convert between Go and JavaScript types.