Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight from my review of #4.
The issue is that dummy payloads were still being constructed as if they were at the start of a block, even the one possibly created to include the
withdrawals
vector. This had the consequence that:EMPTY_TRIE_HASH
(and so were theirtrie_after_roots
), while if we create a payload for withdrawals after existing transactions, these tries would not be empty;GenerationInputs
, namely what's commonly called asExtraBlockData
on the plonky2 side was set toDefault::default()
, which would also cause discrepancies if we were to add a dummy payload after (i.e.gas_used
,txn_number
, etc).The fix is kinda drowning in additional cleanup changes (what I was originally doing when I noticed the issue, apologies for this 🙏🏼).