-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a VerifierState
#13
Conversation
4a4dbbb
to
c1993f0
Compare
|
||
impl VerifierState { | ||
/// Verifies a `block_proof`. | ||
pub fn verify(&self, block_proof: &PlonkyProofIntern) -> ProofGenResult<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BGluth I didn't want to bother creating a new Result / Error type just for one method, so I reused the ProofGen
ones, but let me know if you'd rather me to create a custom pair for ProofVerif
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, creating a separate error seems a bit excessive. We could rename ProofGenResult
to something that's common between ProogGen
and Verifier
I guess, but I don't think it's a big deal if we leave it the way it is.
|
||
impl VerifierState { | ||
/// Verifies a `block_proof`. | ||
pub fn verify(&self, block_proof: &PlonkyProofIntern) -> ProofGenResult<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, creating a separate error seems a bit excessive. We could rename ProofGenResult
to something that's common between ProogGen
and Verifier
I guess, but I don't think it's a big deal if we leave it the way it is.
This PR adds a
VerifierState
, similarly to how theProverState
is constructed to generate proofs, but to verify proofs solely.This is aimed at simplifying 0xPolygonZero/zero-bin#4.