-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions pre 0.2.2 #1557
Bump versions pre 0.2.2 #1557
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muursh can you make sure the comments I made are relevant / applied if necessary before proceeding to a new release?
Hmm nevermind, clarified with Hamy offline, and noticed versions had been pushed anyway.
@@ -1,7 +1,7 @@ | |||
[package] | |||
name = "plonky2_field" | |||
description = "Finite field arithmetic" | |||
version = "0.2.0" | |||
version = "0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this bumped?
|
||
## [0.2.2] - 2024-03-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm mistaken, this is only for starky, so the CHANGELOG should reflect it for clarity.
@@ -26,7 +26,7 @@ log = { workspace = true } | |||
num-bigint = { version = "0.4.3", default-features = false } | |||
|
|||
# Local dependencies | |||
plonky2 = { version = "0.2.0", path = "../plonky2", default-features = false } | |||
plonky2 = { version = "0.2.1", path = "../plonky2", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the bump?
@@ -1,7 +1,7 @@ | |||
[package] | |||
name = "starky" | |||
description = "Implementation of STARKs" | |||
version = "0.2.1" | |||
version = "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG says 0.2.2 but this is bumped to 0.3.0.
No description provided.