Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions pre 0.2.2 #1557

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Bump versions pre 0.2.2 #1557

merged 1 commit into from
Mar 21, 2024

Conversation

hratoanina
Copy link
Contributor

No description provided.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@hratoanina hratoanina merged commit 54cee24 into main Mar 21, 2024
5 checks passed
@hratoanina hratoanina deleted the bump_pre_0.2.2 branch March 21, 2024 18:37
@hratoanina hratoanina restored the bump_pre_0.2.2 branch March 21, 2024 18:39
@hratoanina hratoanina deleted the bump_pre_0.2.2 branch March 21, 2024 18:39
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muursh can you make sure the comments I made are relevant / applied if necessary before proceeding to a new release?

Hmm nevermind, clarified with Hamy offline, and noticed versions had been pushed anyway.

@@ -1,7 +1,7 @@
[package]
name = "plonky2_field"
description = "Finite field arithmetic"
version = "0.2.0"
version = "0.2.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this bumped?


## [0.2.2] - 2024-03-21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, this is only for starky, so the CHANGELOG should reflect it for clarity.

@@ -26,7 +26,7 @@ log = { workspace = true }
num-bigint = { version = "0.4.3", default-features = false }

# Local dependencies
plonky2 = { version = "0.2.0", path = "../plonky2", default-features = false }
plonky2 = { version = "0.2.1", path = "../plonky2", default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the bump?

@@ -1,7 +1,7 @@
[package]
name = "starky"
description = "Implementation of STARKs"
version = "0.2.1"
version = "0.3.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG says 0.2.2 but this is bumped to 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants