Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccInputHash Post Etrog Rework #1510

Draft
wants to merge 6 commits into
base: zkevm
Choose a base branch
from
Draft

AccInputHash Post Etrog Rework #1510

wants to merge 6 commits into from

Conversation

revitteth
Copy link
Collaborator

@revitteth revitteth commented Nov 27, 2024 •
edited
Loading

  • use l1 syncer to populate the accinputhashes from l1
  • calculate accinputhash for batches we don't have stored value
  • separate l1 log retrieval for sequencer logs and ensure only this runs on a fully synced RPC node (i.e. 2x stage progress markers)
  • handle injected batch accinputhash (etrog/post-etrog)
  • handle cross-sequence local calculations (not possible in etrog)

@cla-bot cla-bot bot added the cla-signed label Nov 27, 2024
afa7789
afa7789 reviewed Nov 27, 2024
View reviewed changes
turbo/jsonrpc/zkevm_api.go Outdated Show resolved Hide resolved
@revitteth revitteth changed the title feat(accinputhash): part 1, retrieve from l1 and return AccInputHash Post Etrog Rework Nov 28, 2024
@revitteth revitteth force-pushed the feat/acc-input-hash-final branch 2 times, most recently from 5865823 to aa39c12 Compare November 28, 2024 15:35
@revitteth revitteth force-pushed the feat/acc-input-hash-final branch from f50d3e2 to dd84692 Compare December 9, 2024 10:02
afa7789
afa7789 reviewed Dec 10, 2024
View reviewed changes
zk/acc_input_hash/acc_input_hash.go
return calcConstructor(baseCalc), nil
}

type PreFork7Calculator struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see you using this anywhere. we could remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afa7789 afa7789 afa7789 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revitteth @afa7789