Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcloud version change and update git cmds to push back helm changes for custom action for GCP #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mohitdhaundiyal-searce
Copy link
Contributor

@mohitdhaundiyal-searce mohitdhaundiyal-searce commented Feb 8, 2024

Pull Request Template

Description

  • Latest version of gcloud was not working with binary attestation of images. Fixed this issue with gcloud version '455.0.0'.

  • Updated the git commands to push back helm changes for custom action for GCP build pipeline.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

Before you submit your pull request, please make sure you have completed the following:

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run lint to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if appropriate):

Include any screenshots that will help explain your changes.

Additional context

Add any other context about the pull request here.

@mohitdhaundiyal-searce mohitdhaundiyal-searce changed the title Gcloud version chnage for custom action for GCP Gcloud version change and update git cmds to push back helm changes for custom action for GCP Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant