Skip to content

Commit

Permalink
slub: Enable irqs for __GFP_WAIT
Browse files Browse the repository at this point in the history
SYSTEM_RUNNING might be too late for enabling interrupts. Allocations
with GFP_WAIT can happen before that. So use this as an indicator.

Signed-off-by: Thomas Gleixner <[email protected]>
  • Loading branch information
KAGA-KOKO authored and Sebastian Andrzej Siewior committed Apr 3, 2020
1 parent d18a0a1 commit c01e10f
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion mm/slub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1647,10 +1647,18 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
void *start, *p, *next;
int idx;
bool shuffle;
bool enableirqs = false;

flags &= gfp_allowed_mask;

if (gfpflags_allow_blocking(flags))
enableirqs = true;

#ifdef CONFIG_PREEMPT_RT
if (system_state > SYSTEM_BOOTING)
enableirqs = true;
#endif
if (enableirqs)
local_irq_enable();

flags |= s->allocflags;
Expand Down Expand Up @@ -1709,7 +1717,7 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
page->frozen = 1;

out:
if (gfpflags_allow_blocking(flags))
if (enableirqs)
local_irq_disable();
if (!page)
return NULL;
Expand Down

0 comments on commit c01e10f

Please sign in to comment.