-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repeatedly showing postinstall to once a day #597
Conversation
This uses a temp file and checks the timestamp (useful for local development) and it means that the request for support is only shown on that particular machine once a day.
Thanks. One moment - I'm ready to limit it to one message per |
Sorry, super slack on reply to this thread (though now it might be that npm will be shooting us down anyway). I added the try/catch on write and I've changed the check to be on a 5 minute timeout as you requested. |
Thanks. I already reworked it by a little more complex logic. About NPM - seems new rules are not a problem. |
I was hired to discover and fix the reason node build logs just doubled in size. It's because someone added something that uses core-js, and each sub-package that uses it also shows an add saying zloirock is looking for a good job. While I understand we all need to eat, 50+ ads spamming the same thing is apparently a big enough issue to pay someone to get rid of. I see this has been a problem for people for a while... Might want to fix this before "zloirock is looking for a good job" becomes a meme or synonymous with spam. That would probably not be the outcome you're looking for. |
This is still occurring. |
It's possible to add one of many environment variables to hide the ads: https://github.com/zloirock/core-js/blob/master/packages/core-js/postinstall.js#L31 Options available since https://github.com/zloirock/core-js/releases/tag/v3.3.0 , mid October. |
So instead of outright removing the spam, making people dig into changelogs/github issues to figure out that it's even possible to disable it is better? |
|
This uses a temp file and checks the timestamp (useful for local development) and it means that the request for support is only shown on that particular machine once a day.
Ref #548
Hopefully this helps calm people down!