Fix RegExp methods in old browsers #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Nov 12, 2018
| // `RegExp.prototype[@@match]` method | ||
| // https://tc39.github.io/ecma262/#sec-regexp.prototype-@@match | ||
| function (regexp) { | ||
| var res = maybeCallNative(nativeMatch, regexp, this); |
There was a problem hiding this comment.
All those "maybeCallNative" calls are to fix the infinite recursion in Chrome 50
nicolo-ribaudo
commented
Nov 12, 2018
| delegates: delegates, | ||
| replaceSupportsNamedGroups: replaceSupportsNamedGroups | ||
| }); | ||
| var splitWorksWithOverwrittenExec = KEY === 'split' && (function () { |
There was a problem hiding this comment.
This is the fix for Chrome 51.
nicolo-ribaudo
force-pushed
the
fix-regexs-on-old-browsers
branch
from
194442e to
34c4808
Compare
IE8 is not fully fixed yet
nicolo-ribaudo
force-pushed
the
fix-regexs-on-old-browsers
branch
2 times, most recently
from
20287c1 to
9fdd727
Compare
nicolo-ribaudo
force-pushed
the
fix-regexs-on-old-browsers
branch
from
9fdd727 to
b8f73b1
Compare
nicolo-ribaudo
force-pushed
the
fix-regexs-on-old-browsers
branch
from
0a77b65 to
823756a
Compare
zloirock
force-pushed
the
master
branch
2 times, most recently
from
c62cbda to
626f321
Compare
|
I'm having difficulty debbuging Safari 9: if I run all the tests, the Also, if I add a breakpoint and manually step through the test it passes. |
nicolo-ribaudo
changed the title
|
@zloirock There is a test that is only failing sometimes in Safari 9 and always passes when I run it step-by-step using the dev tools 😕 Apart from that, this PR is ready to be reviewed. EDIT: If I disable the cookies, Safari consistently fails the test. But if I run it with devtools open Safari crashes 😕 |
|
Done! |
nicolo-ribaudo
force-pushed
the
fix-regexs-on-old-browsers
branch
from
ed0276f to
d3fa95e
Compare
zloirock
approved these changes
Nov 17, 2018
zloirock
added a commit
that referenced
this pull request
Nov 18, 2018
nicolo-ribaudo
added a commit
to nicolo-ribaudo/core-js
that referenced
this pull request
Dec 3, 2018
Merged
zloirock
added a commit
that referenced
this pull request
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref - #411
Chrome 50 (aeacd0d - Disable whitespaces in the diff)
Chrome 51 (aeacd0d - Disable whitespaces in the diff)
IE 8 (5bd11fc, b8f73b1, 823756a)
Safari 9 (ed0276f)
