[Feedback needed] fix; exit all manually entered NodeJS domains #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found an issue with core-js Promises when used in Node 4x. Using the following script demonstrates that when domains are in use and a
then()
callback throws an error, the active domain is left in an entered state. This causes the domain to not be garbage collected, leading to memory leaks of not just the domain, but of anything added to the domain (a pretty big leak when using them to handle http server errors as outlined in the domain documentation).This PR fixes the issue I'm facing but I'm not sure how / where to write tests for this project. I'm also not sure if I need to update both
modules/es6.promise.js
andlibrary/modules/es6.promise.js
. Please advise.