Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Deposit and DepositAndCall methods for E2E Solana API #3282

Open
lumtis opened this issue Dec 12, 2024 · 0 comments
Open

Separate Deposit and DepositAndCall methods for E2E Solana API #3282

lumtis opened this issue Dec 12, 2024 · 0 comments
Labels
chain:solana E2E E2E tests related good first issue Good for newcomers

Comments

@lumtis
Copy link
Member

lumtis commented Dec 12, 2024

We have these two depositAndCall method for SOL and SPL:

node/e2e/runner/solana.go

Line 202 in 5f35a90

func (r *E2ERunner) SPLDepositAndCall(

node/e2e/runner/solana.go

Line 352 in 5f35a90

func (r *E2ERunner) SOLDepositAndCall(

Currently you need to provide emtpy data for simple deposit but the API would be cleaner if we could separate into a Deposit and DepositAndCall instead.

In practice you should be able to perform a call with empty data.
@lumtis lumtis added good first issue Good for newcomers E2E E2E tests related chain:solana labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chain:solana E2E E2E tests related good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lumtis