Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zetacore : ZetaAccounting is incorrectly set during InitGenesis of crosschain module #3243

Open
kingpinXD opened this issue Dec 4, 2024 · 0 comments
Open

zetacore : ZetaAccounting is incorrectly set during InitGenesis of crosschain module #3243

kingpinXD opened this issue Dec 4, 2024 · 0 comments
Assignees
@kingpinXD
Labels
bug Something isn't working zetacore Issues related to ZetaCore

Comments

@kingpinXD
Copy link
Contributor

We set ZetaAccounting here
https://github.com/zeta-chain/zeta-node/blob/a8236ed03212ab3c30efd5dbccc3d62d582e7900/x/crosschain/genesis.go#L13-L13

This directly copies and sets the existing value to state.

However,
The value is also updated ( Aborted amount is added ) when saving the CCTX's
https://github.com/zeta-chain/zeta-node/blob/a8236ed03212ab3c30efd5dbccc3d62d582e7900/x/crosschain/genesis.go#L47-L53

This behaviour should be modified to properly set accounting
@kingpinXD kingpinXD added the bug Something isn't working label Dec 4, 2024
@kingpinXD kingpinXD self-assigned this Dec 4, 2024
@kingpinXD kingpinXD added the zetacore Issues related to ZetaCore label Dec 4, 2024
@kingpinXD kingpinXD mentioned this issue Dec 4, 2024
Merged
5 tasks
@kingpinXD kingpinXD changed the title zetacore : ZetaAccounting is incorrectly set during InitGenesis of corsschain module zetacore : ZetaAccounting is incorrectly set during InitGenesis of crosschain module Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingpinXD kingpinXD

Labels
bug Something isn't working zetacore Issues related to ZetaCore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kingpinXD